Conversation
Mono dequeue
fix n_cameras
dev: Reduce large django queries
Added isMono field in DB + logic behind it for dequeue and n cameras
… the past week in the dequeue view
carmichaelong
approved these changes
Jun 10, 2025
Contributor
carmichaelong
left a comment
carmichaelong
left a comment
There was a problem hiding this comment.
LGTM. I tested end-to-end with the dev website and app with some new trials.
Since we're touching the DB, I'll ask @AlbertoCasasOrtiz to double check that this looks OK too.
AlbertoCasasOrtiz
approved these changes
Jun 10, 2025
Member
AlbertoCasasOrtiz
left a comment
AlbertoCasasOrtiz
left a comment
There was a problem hiding this comment.
Just reviewed, everything seems ok!
Contributor
|
@suhlrich We're all good from our end on the review. I think since the migration and merge should be coordinated in that order, please feel free to do both on your end whenever you think is a good time to do so. Thanks! |
Collaborator
Author
|
Great, Thanks! Will do this week likely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added an isMono field to Session and indexed it, facilitating more efficient dequeueing for mono or multi-camera backends.
We indexed updated-at and only search trials updated in the past week in dequeue (should help offload API CPU)
We tested both normal opencap and monocular pipelines with this, and they both work for both collection and backend. For now the monocular viewer is on a branch and is to be run locally until we release. This should not change the UX in the prod workflow for now.
We need to migrate the prod database as well. We can do this once someone reviews.